Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: reduce unnecessary GetCwd calls #53064

Merged
merged 1 commit into from
May 22, 2024
Merged

src: reduce unnecessary GetCwd calls #53064

merged 1 commit into from
May 22, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented May 20, 2024

Removes unnecessary GetCwd() call.

@anonrig anonrig requested a review from RafaelGSS May 20, 2024 01:23
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 20, 2024
RafaelGSS
RafaelGSS reviewed May 20, 2024
View reviewed changes
src/path.cc Show resolved Hide resolved
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59315/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit 695cd8b into nodejs:main May 22, 2024
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 695cd8b

targos pushed a commit that referenced this pull request Jun 1, 2024
@anonrig @targos
src: reduce unnecessary GetCwd calls
4a2c6ff 
PR-URL: #53064
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this pull request Jun 1, 2024
@anonrig @lukins-cz
src: reduce unnecessary GetCwd calls
d6de05e 
PR-URL: nodejs#53064
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@trivikr trivikr trivikr approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@anonrig @nodejs-github-bot @benjamingr @lpinca @richardlau @trivikr @RafaelGSS