Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(echo): Mvp test suite #5583

Merged
merged 37 commits into from
May 28, 2024
Merged

Conversation

djabarovgeorge
Copy link
Contributor

What changed? Why was the change needed?

  • Define a basic MVP journey for SDK
  • Add tests for basic MVP journey

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

djabarovgeorge and others added 30 commits May 6, 2024 11:45
…-packages-to-the-monorepo

# Conflicts:
#	pnpm-lock.yaml
…-packages-to-the-monorepo

# Conflicts:
#	pnpm-lock.yaml
…o-the-monorepo' into NV-3670/relocate-echo-packages-to-the-monorepo
…o-the-monorepo' into nv-3653-add-ci-for-testing-sdk-cli

# Conflicts:
#	packages/cli-next/src/start-studio.ts
Copy link

linear bot commented May 16, 2024

Copy link

netlify bot commented May 16, 2024

Deploy Preview for dev-web-novu failed. Why did it fail? →

Name Link
🔨 Latest commit 3db67fe
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/6655a8ff2a05150008ca98bb

Copy link

netlify bot commented May 16, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit 3db67fe
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/6655a8ff9198340008808e50
😎 Deploy Preview https://deploy-preview-5583--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@novuhq novuhq deleted a comment from ainouzgali May 16, 2024
@djabarovgeorge djabarovgeorge requested review from a team, SokratisVidros and ainouzgali and removed request for a team May 27, 2024 10:22
@djabarovgeorge djabarovgeorge changed the title Nv 3672 add sdk mvp test suite feat: add sdk mvp test suite. nv-3672 May 27, 2024
packages/echo/src/client.test.ts Dismissed Show dismissed Hide dismissed
@djabarovgeorge djabarovgeorge changed the title feat: add sdk mvp test suite. nv-3672 feat(echo): add sdk mvp test suite. nv-3672 May 27, 2024
@rifont rifont changed the title feat(echo): add sdk mvp test suite. nv-3672 test(echo): Sdk mvp test suite May 28, 2024
@rifont rifont changed the title test(echo): Sdk mvp test suite test(echo): Mvp test suite May 28, 2024
@rifont rifont changed the title test(echo): Mvp test suite test(echo): Mvp test suite [NV-3672] May 28, 2024
@rifont rifont changed the title test(echo): Mvp test suite [NV-3672] test(echo): Mvp test suite May 28, 2024
Copy link
Contributor

@rifont rifont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@djabarovgeorge djabarovgeorge merged commit 06adafd into next May 28, 2024
20 of 24 checks passed
@djabarovgeorge djabarovgeorge deleted the nv-3672-add-sdk-mvp-test-suite branch May 28, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants