fix(core): remove duplicate js-yaml packages

[Phillip9587]

Current Behavior

nx package depends on both js-yaml and @zkochan/js-yaml

Expected Behavior

nx should only depend on one of the both

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	May 17, 2024 2:34pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 24dd26f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --targets=e2e,e2e-ci --base=937019b172efb0631119de25f16b2f5a0dc908b4 --head=24dd26f5614ab7cebdb617d018e432ec15c3276e --parallel=1
• nx affected --targets=lint,test,build --base=937019b172efb0631119de25f16b2f5a0dc908b4 --head=24dd26f5614ab7cebdb617d018e432ec15c3276e --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=937019b172efb0631119de25f16b2f5a0dc908b4 --head=24dd26f5614ab7cebdb617d018e432ec15c3276e
• nx documentation --no-dte
• nx affected -t e2e-macos-ci --parallel=1 --base=937019b172efb0631119de25f16b2f5a0dc908b4 --head=24dd26f5614ab7cebdb617d018e432ec15c3276e

---

Sent with 💌 from NxCloud.

[meeroslav]

Thank you @Phillip9587 for this PR.

The two failing lint tasks are related to a limitation in the dependency-checks rule. Can you please add js-yaml to the list of ignoredDependencies in the corresponding .eslintrc.json, and we will address that issue separately?

You also need to rebase with the latest pnpm-lock file changes.

[meeroslav]

The dependency-checks rule is failing with alias dependencies. This should be resolved elsewhere.

Just include the override in the ignoredDependencies to get this PR over the line and we will address this issue separately.

[Phillip9587]

@meeroslav Done. I created #23469 to track the issue with the lint rule

[meeroslav]

Thank you! Merging it in as soon as the build it green.

[Phillip9587]

@meeroslav CI is finally green

[nzacca]

@Phillip9587

Hello! May I inquire why Nx is using the package from zkochan vs the official package?

We are using js-yaml directly in our project but this change is now causing a conflict as it expects zkochan's package as a peer dependency. I can't seem to find the actual source for the zkochan package to compare what is different to assess if it is OK to change.

Any insight for the differences would be appreciated! Thank you!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.