-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): prevent graph output from being truncated #23446
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 481413f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
docs/generated/cli/affected.md
Outdated
@@ -65,6 +65,24 @@ Use the currently executing project name in your command.: | |||
nx affected -t build --tag=$NX_TASK_TARGET_PROJECT:latest | |||
``` | |||
|
|||
Preview the task graph that Nx would run inside a webview.: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview the task graph that Nx would run inside a webview.: | |
Preview the task graph that Nx would run inside a webview: |
Please fix this everywhere
@@ -53,13 +53,13 @@ Show affected projects in the workspace, excluding end-to-end projects: | |||
nx show projects --affected --exclude=*-e2e | |||
``` | |||
|
|||
Show detailed information about "my-app" in a json format.: | |||
Show detailed information about "my-app" in a json format: | |||
|
|||
```shell | |||
nx show project my-app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure this is correct..
docs/generated/cli/graph.md
Outdated
Print the project graph as JSON to the console: | ||
|
||
```shell | ||
nx graph --file=stdout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only show --print
5b9cd52
to
03685f9
Compare
docs/generated/cli/graph.md
Outdated
@@ -89,7 +95,7 @@ Exclude certain projects from being processed | |||
|
|||
Type: `string` | |||
|
|||
Output file (e.g. --file=output.json or --file=dep-graph.html) | |||
Output file (e.g. --file=output.json or --file=dep-graph.html). Provide --file=stdout to print the project graph in the terminal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not recommend this.
docs/generated/cli/graph.md
Outdated
|
||
Type: `boolean` | ||
|
||
Print the project graph in the terminal. (equivalent to --file=stdout) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have to mention that it's equivalent?
03685f9
to
481413f
Compare
Current Behavior
--graph stdout and --file stdout aren't documented. When printing graph to stdout, its possible for some output to get missed.
Expected Behavior
Existing flags are documented, and
--print
is more discoverable. We await stdout finishing before exiting the program.Related Issue(s)
Fixes #18689