Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding packages in workspaces #11177

Merged
merged 34 commits into from
May 21, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented May 19, 2024

What does this PR do?

Fixes bugs involving:

  • adding dependencies to workspaces
  • editing workspace package.json
  • diffing lockfiles with workspace dependencies

fixes #11064
fixes #9413
fixes #7913
fixes #7844
fixes #7547

Also adds a better error message when the directory given to --cwd doesn't exist.

How did you verify your code works?

added tests

Copy link

github-actions bot commented May 19, 2024

@dylan-conway, your commit has failing tests :(

💪 3 failing tests Darwin AARCH64

💻 3 failing tests Darwin x64 baseline

💻 2 failing tests Darwin x64

🐧🖥 1 failing tests Linux x64 baseline

🐧🖥 1 failing tests Linux x64

🪟💻 9 failing tests Windows x64 baseline

🪟💻 10 failing tests Windows x64

View logs

@dylan-conway dylan-conway marked this pull request as ready for review May 21, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants