fix: exclude use-openssl-ca from threads worker args

[viceice]

↪️ Pull Request

use-openssl-ca should not send to Worker because it's not supported.

• closes Can't run Parcel with NODE_OPTIONS set to --use-openssl-ca #6569

💻 Examples

We use a node wrapper wich calls node --use-openssl-ca ... and that fails with default threads worker

🚨 Test instructions

✔️ PR Todo

• Added/updated unit tests for this change
• Filled out test instructions (In case there aren't any unit tests)
• Included links to related issues/PRs

[mischnic]

We already have handling of various Node flags here:

parcel/packages/core/workers/src/Worker.js

Lines 50 to 65 in d58e336

	async fork(forkModule: FilePath) {
	let filteredArgs = [];
	if (process.execArgv) {
	filteredArgs = process.execArgv.filter(
	v => !/^--(debug|inspect|no-opt|max-old-space-size=)/.test(v),
	);
	for (let i = 0; i < filteredArgs.length; i++) {
	let arg = filteredArgs[i];
	let isArgWithParam =
	((arg === '-r' || arg === '--require') &&
	filteredArgs[i + 1] === '@parcel/register') ||
	arg === '--title';
	if (isArgWithParam) {
	filteredArgs.splice(i, 2);
	i--;

So we should put this flag there as well

[viceice]

That only filters cli args but doesn't filter the NODE_OPTIONS env, that's why i added it to the threads worker. It should be passed to the process worker, which can otherwise fail is the use-openssl-ca flag is missing

[mischnic]

However I still get

Error: Initiated Worker with invalid NODE_OPTIONS env variable: --use-openssl-ca is not allowed in NODE_OPTIONS

with your change because that flag is being passed along here

parcel/packages/core/workers/src/threads/ThreadsWorker.js

Line 38 in d58e336

env: process.env,

[viceice]

I can try to fix it on Monday

Outdated

[viceice]

sorry, but very busy with other open source projects 🤗