Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stmtsummary, slow log: add additional information into record #53366

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

zeminzhou
Copy link
Contributor

@zeminzhou zeminzhou commented May 17, 2024

What problem does this PR solve?

Issue Number: close #53382

Problem Summary:

What changed and how does it work?

support to add additional information into slow log / stmtsummary.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2024
Copy link

ti-chi-bot bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sdojjy, yudongusa for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

tiprow bot commented May 17, 2024

Hi @zeminzhou. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5790%. Comparing base (1c4a9c6) to head (2dbaefc).
Report is 24 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53366        +/-   ##
================================================
+ Coverage   72.4996%   74.5790%   +2.0793%     
================================================
  Files          1505       1505                
  Lines        429646     432333      +2687     
================================================
+ Hits         311492     322430     +10938     
+ Misses        98849      89913      -8936     
- Partials      19305      19990       +685     
Flag Coverage Δ
integration 49.1469% <16.6666%> (?)
unit 71.3380% <100.0000%> (-0.0610%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.3858% <ø> (+8.9614%) ⬆️

Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: zzm <zhouzemin@pingcap.com>
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
zeminzhou and others added 3 commits May 21, 2024 17:11
Co-authored-by: ystaticy <y_static_y@sina.com>
Co-authored-by: ystaticy <y_static_y@sina.com>
Signed-off-by: zzm <zhouzemin@pingcap.com>
@zeminzhou
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented May 21, 2024

@zeminzhou: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add additional information into slow log / stmtsummary
2 participants