feat(eventbridge): add EventBridge checks #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4020 +/- ##
==========================================
- Coverage 86.34% 86.29% -0.05%
==========================================
Files 778 783 +5
Lines 24368 24537 +169
==========================================
+ Hits 21040 21175 +135
- Misses 3328 3362 +34 ☔ View full report in Codecov by Sentry. |
jfagoagas
requested changes
May 17, 2024
There was a problem hiding this comment.
Great job @sergargar 👏 Please review my comments when you get a chance, thanks!
...idge/eventbridge_bus_cross_account_access/eventbridge_bus_cross_account_access.metadata.json
Show resolved
Hide resolved
...idge/eventbridge_bus_cross_account_access/eventbridge_bus_cross_account_access.metadata.json
Outdated
Show resolved
Hide resolved
...ces/eventbridge/eventbridge_bus_cross_account_access/eventbridge_bus_cross_account_access.py
Outdated
Show resolved
Hide resolved
| "CheckTitle": "Ensure that your AWS EventBridge event bus is not exposed to everyone", | ||
| "CheckType": [], | ||
| "ServiceName": "eventbridge", | ||
| "SubServiceName": "", |
There was a problem hiding this comment.
Suggested change
| "SubServiceName": "", | |
| "SubServiceName": "eventbus", |
maybe?
There was a problem hiding this comment.
Is that not a resource type?
...iders/aws/services/eventbridge/eventbridge_bus_exposed/eventbridge_bus_exposed.metadata.json
Outdated
Show resolved
Hide resolved
...idge/eventbridge_bus_cross_account_access/eventbridge_bus_cross_account_access.metadata.json
Show resolved
Hide resolved
...dge_schema_registry_cross_account_access/eventbridge_schema_registry_cross_account_access.py
Outdated
Show resolved
Hide resolved
prowler/providers/aws/services/eventbridge/eventbridge_service.py
Outdated
Show resolved
Hide resolved
prowler/providers/aws/services/eventbridge/eventbridge_service.py
Outdated
Show resolved
Hide resolved
prowler/providers/aws/services/eventbridge/eventbridge_service.py
Outdated
Show resolved
Hide resolved
jfagoagas
requested changes
May 20, 2024
prowler/providers/aws/lib/iam/iam.py
Outdated
There was a problem hiding this comment.
what if we put this into the IAM service folder like prowler/providers/aws/services/iam/lib/policy.py
There was a problem hiding this comment.
Please add tests for this function not just the ones used in the checks.
...idge/eventbridge_bus_cross_account_access/eventbridge_bus_cross_account_access.metadata.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the following EventBridge checks:
eventbridge_bus_exposed: Ensure that your AWS EventBridge event bus is not exposed to everyone.eventbridge_bus_cross_account_access: Ensure that AWS EventBridge event buses do not allow unknown cross-account access for the delivery of events.eventbridge_schema_registry_cross_account_access: Ensure that access to EventBridge schema registries is restricted to accounts within your AWS Organization or specifically authorized accounts.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.