SSR support #202
Open
SSR support #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neonox31
force-pushed
the
next
branch
2 times, most recently
from
7cba146
to
97ba298
Compare
Neonox31
force-pushed
the
next
branch
2 times, most recently
from
20086b9
to
ee186a8
Compare
|
any updates on this? |
|
any news on this? |
|
Hi @FallenRiteMonk can you plz help for this? |
|
@MarouaniALA I'm sorry but currently I'm short on time. |
Neonox31
force-pushed
the
next
branch
11 times, most recently
from
b83fbe4
to
83cf6f5
Compare
jeremy-eychenne
force-pushed
the
next
branch
3 times, most recently
from
7cb331d
to
a70ba9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to lack of time, I wasn't able to test this aproprietly, but this should fix #108.
@quentin-ol since this will not break any existing application, could you please merge this so I can try it easily without having to set up server side rendering (SSR) for your example project.
If not I'll hopefully find some time in near future to test this.
Further on, in combination with the proposal you made in #108 (comment), this could be extended to render a 'alt-img' if rendered on a server, making this module fully SSR capable.