add support to onFocusOnly option for interactions
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neonox31
force-pushed
the
next
branch
11 times, most recently
from
b83fbe4
to
83cf6f5
Compare
jeremy-eychenne
force-pushed
the
next
branch
3 times, most recently
from
7cb331d
to
a70ba9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to
onFocusOnlyoption that is available onol/interaction/MouseWheelZoomand onol/interaction/DragPan(andol/interaction.defaultsfor completeness).For the site I'm developing right now this is a must, since we have lots of scrollable content on a page with a map. Without
onFocusOnlythe map traps the mouse wheel, resulting in a bad user experience.Please note that the
tabindexthing in<aol-map>is needed for thefocusWithTabindexcondition to work inside OpenLayers. I don't expect any breaking change in this PR, given that in using[attr.tabindex]withnullwill effectively not set tabindex (as it occurs before the PR). Also,tabindexproperty didn't exist inaol-mapaltogether (so nobody should be using it).