Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fallback to git diff command to get diff of a GitHub pull request on doghouse #1722

Merged
merged 5 commits into from
Jun 1, 2024

Conversation

massongit
Copy link
Contributor

@massongit massongit commented Apr 25, 2024

  • Updated Unreleased section in CHANGELOG or it's not notable changes.

Fix #1696 (comment)

Similar to #1697 and #1714, I add a fallback to git diff command to get diff of a GitHub pull request on doghouse.

case "github-check":
return runDoghouse(ctx, r, w, opt, isProject, false, false)
case "github-pr-check":
return runDoghouse(ctx, r, w, opt, isProject, true, false)
case "github-pr-annotations":
return runDoghouse(ctx, r, w, opt, isProject, true, true)

This will enable fallback even if the reporter is github-check, github-pr-check or github-pr-annotations.

Note that this only runs if git command is installed.

@massongit massongit changed the title doghouse: Add a fallback to git diff command Add a fallback to git diff command to get diff of a GitHub pull request on doghouse Apr 25, 2024
@massongit massongit marked this pull request as ready for review April 25, 2024 15:30
@massongit
Copy link
Contributor Author

@haya14busa Please review it.

@dprotaso
Copy link

Hey just following up - we've been hitting this issue again.

@massongit massongit requested review from shogo82148 and haya14busa and removed request for haya14busa May 21, 2024 11:03
@massongit
Copy link
Contributor Author

@haya14busa @shogo82148 Please review it.

Copy link
Member

@haya14busa haya14busa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the very late review.

I added some commits to this PR and LGTM.

@haya14busa haya14busa merged commit 4690af3 into reviewdog:master Jun 1, 2024
15 checks passed
@massongit massongit deleted the add_fallback branch June 1, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Pull Request diff API responds with 406 — diff too large
3 participants