-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement display of missing key pairs in wallet settings #20094
Conversation
Jenkins BuildsClick to see older builds (61)
|
6986930
to
31c5c25
Compare
179403d
to
1881b4b
Compare
1881b4b
to
3bc7033
Compare
4efefe5
to
39e46f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 🔥, LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🚀 @seanstrom 🙌
You might need to add this issue (#19733) to this PR as it's done here. Thanks!
src/status_im/contexts/settings/wallet/keypairs_and_accounts/actions/view.cljs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question: I can't find this type missing-keypair
for the drawer-top
component in the Design System. If it's not too much trouble, would you help add the link to the design?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah good question 🙏
I don't think it's an official extension of the component, but here's the designs that feature the drawer-top component with a missing key-pair: https://www.figma.com/design/hLFPHYnuM0pOzgiabtqQ6k/Descoped-Wallet-settings-for-Mobile?node-id=232-33083&t=4nFqEVTIOAcfu0JS-4
Maybe the design system should be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I'll double check with design team 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still double checking with the design team, but for the moment I've refactored drawer-top component to use a :stored
field (similar to the quo/keypair
component) for describing whether the key pair is :on-device
, :on-keycard
, or :missing
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be fine as we have the same in the quo/keypair
component. Let's post this information to the Design team to keep them updated. 👍
8f03a9b
to
fd03d26
Compare
15c3582
to
22b1dff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
2c6a932
to
9de8613
Compare
77% of end-end tests have passed
Failed tests (10)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (40)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
|
@status-im/mobile-qa can you review these E2E results please? 🙏 |
9de8613
to
44c8c3f
Compare
Hi @seanstrom, thanks for the PR! E2E failures are not related |
44c8c3f
to
5b201ae
Compare
Note, this PR is going to use |
fixes #20033
fixes #19733
Summary
Platforms
Areas that maybe impacted
Functional
Steps to test
To test these changes there are some requirements, the user account for testing will need with two devices, and both of those devices must be synced to the user account.
Once the account and devices are setup to sync between the devices:
After changes screen capture
Missing.Key.Pairs.Demo.mov
status: ready