Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewed translation for French (fr) #54968

Merged
merged 1 commit into from
May 21, 2024

Conversation

camilleislasse
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #54950
License MIT

@carsonbot carsonbot added this to the 5.4 milestone May 17, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@camilleislasse camilleislasse changed the title Update security.fr.xlf [Security] Reviewed translation for French (fr) May 17, 2024
@carsonbot carsonbot changed the title [Security] Reviewed translation for French (fr) Reviewed translation for French (fr) May 21, 2024
@fabpot
Copy link
Member

fabpot commented May 21, 2024

Thank you @camilleislasse.

@fabpot fabpot merged commit f0d728e into symfony:5.4 May 21, 2024
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants