[Mime] Support custom encoders in mime parts #54975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KDederichs
force-pushed
the
feat/custom_mime_encoders
branch
from
a4bf114
to
620d561
Compare
carsonbot
changed the title
|
Dunno, those test failures look not related and kind of random? |
|
Also can this still be squeezed into 7.1 or do we have feature freeze since we got RC1 now? (I kind of really need this :D) |
|
We have feature freeze for over two weeks already. I see no reason to make an exception here, sorry. |
|
Ah too bad, guess I'll copy stuff around till 7.2 then |
Yeah, too bad that Composer cannot install dev snapshots. Oh wait. |
derrabus
requested changes
May 17, 2024
KDederichs
force-pushed
the
feat/custom_mime_encoders
branch
2 times, most recently
from
f2c55db
to
1af7ac2
Compare
derrabus
reviewed
May 21, 2024
| if ('quoted-printable' !== $encoding && 'base64' !== $encoding && '8bit' !== $encoding) { | ||
| throw new InvalidArgumentException(sprintf('The encoding must be one of "quoted-printable", "base64", or "8bit" ("%s" given).', $encoding)); | ||
| if (!\in_array($encoding, self::DEFAULT_ENCODERS) && !\array_key_exists($encoding, self::$encoders)) { | ||
| throw new InvalidArgumentException('The encoding must be one of "quoted-printable", "base64", or "8bit". In case you are trying to use a custom encoder, please add it first.'); |
There was a problem hiding this comment.
Shall we just list all available encodings? I don't think the second sentence is necessary then.
There was a problem hiding this comment.
Sure, sounds good.
I'll change it.
KDederichs
force-pushed
the
feat/custom_mime_encoders
branch
from
1af7ac2
to
7d7e072
Compare
derrabus
approved these changes
May 21, 2024
derrabus
changed the title
fabpot
approved these changes
May 31, 2024
|
Thank you @KDederichs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow adding custom encoders to Text Parts