Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Answer:42 static vs dynamic #906

Closed

Conversation

LMFinney
Copy link
Sponsor Contributor

Command to generate the lib:
nx g @nx/angular:library user --directory libs/static-dynamic-import --projectNameAndRootFormat derived

Checklist for challenge submission

  • Start your PR message with Answer:${challenge_number}

Warning:

  • If you want feedback or review, you must support the project on GitHub:

Alternatively, you can still submit your PR to join the list of answered challenges or to be reviewed by a community member. 馃敟

nx g @nx/angular:library user
 --directory libs/static-dynamic-import
 --projectNameAndRootFormat derived
remove boilerplate component
move dependencies from users lib to user lib
update imports
tweak project prefixes
tweak the import alias for consistency
@github-actions github-actions bot added 42 static dynamic import answer answer sponsor sponsor the project to be reviewed PR requests a review labels May 13, 2024
@tomalaforge
Copy link
Owner

Lots of generated file for a small fix. Nice job. Easy to fix when you are used to nx, hard when not

@tomalaforge tomalaforge removed the to be reviewed PR requests a review label May 16, 2024
@LMFinney
Copy link
Sponsor Contributor Author

Lots of generated file for a small fix. Nice job. Easy to fix when you are used to nx, hard when not

Yes, it's a code reorganization fix. If you know how to generate a lib in nx, it's easy.

Copy link

This pull request is stale because it has been open for 15 days with no activity.

@github-actions github-actions bot added the stale label May 27, 2024
Copy link

This pull request was closed because it has been inactive for 5 days since being marked as stale.

@github-actions github-actions bot closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
42 static dynamic import answer answer sponsor sponsor the project stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants