fix: new-request error when create request from cURL if some parameter(s) in form-urlencoded type data missing '=' #2290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When create a new
form-urlencoded
request from cURL, if some parameter(s) inform-urlencoded
type data missing=
, likeparam2
parameter below, toast thatError invoking remote method 'renderer:new-request': TypeError: Cannot read properties of null (reading 'includes')
. #2288e.g.:
Why?
cURL
command, app will usequery-string
to parseform-urlencoded
type data string. If some parameter(s) inform-urlencoded
type data string missing=
,query-string
will set value asnull
(Missing=
should benull
· sindresorhus/query-string).But it isn't a bug, just a feature following W3 specification(https://www.w3.org/TR/2012/WD-url-20120524/#collect-url-parameters).
bru
type data inbruno-lang
v2, will executevalue.includes('\n');
, then throw error.Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.