Target: add OpenHarmonyOS ABI #20011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,7 +45,8 @@ pub fn requiresPIC(target: std.Target, linking_libc: bool) bool { | |||
| return target.isAndroid() or | |||
| target.os.tag == .windows or target.os.tag == .uefi or | |||
| osRequiresLibC(target) or | |||
| (linking_libc and target.isGnuLibC()); | |||
| (linking_libc and target.isGnuLibC()) or | |||
| (target.abi == .ohos and target.cpu.arch == .aarch64); | |||
There was a problem hiding this comment.
Openharmony support arm64-v8a armeabi-v7a x86_64, so should we remove target.cpu.arch == .aarch64 ?
There was a problem hiding this comment.
I don't know, this just matches what Clang does https://github.com/llvm/llvm-project/blob/6733a505a1afb8eb4db2f6d85426d79ff0dc5eee/clang/lib/Driver/ToolChains/CommonArgs.cpp#L1735-L1737
There was a problem hiding this comment.
ok thanks for your work, i will try to test it.
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should match how Clang/LLVM handle it but I haven't tested it.
Closes #20009